From 0af9524e16fbae14ef15fcf0262f8c1a92a83030 Mon Sep 17 00:00:00 2001
From: Arun Chandrasekaran <arun@paravision.ai>
Date: Thu, 7 Jul 2022 02:08:47 -0700
Subject: [PATCH] Always set thread names on POSIX platforms (#3384)

* chore: gitignore vim .swp files

* feat(POSIX): Always set thread names.

I'm not sure about the original intent to hide it under a DEBUG macro.

Naming the threads in release mode makes it easier to see runtime
application and know which thread pool uses how many threads and what
their names are. Firefox, Chromium and many other apps do this on Linux.
---
 .gitignore                      | 7 +++++++
 Foundation/src/Thread_POSIX.cpp | 8 --------
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/.gitignore b/.gitignore
index a326021e30..b334caf220 100644
--- a/.gitignore
+++ b/.gitignore
@@ -144,3 +144,10 @@ cmake-build/
 *.bak
 stage/
 releases/
+
+# vim #
+#######
+*.orig
+*.swp
+*.vim
+tags
diff --git a/Foundation/src/Thread_POSIX.cpp b/Foundation/src/Thread_POSIX.cpp
index e290622167..ceab76e828 100644
--- a/Foundation/src/Thread_POSIX.cpp
+++ b/Foundation/src/Thread_POSIX.cpp
@@ -62,9 +62,6 @@ namespace
 #endif
 
 
-#if defined(POCO_POSIX_DEBUGGER_THREAD_NAMES)
-
-
 namespace {
 void setThreadName(pthread_t thread, const std::string& threadName)
 {
@@ -83,9 +80,6 @@ void setThreadName(pthread_t thread, const std::string& threadName)
 }
 
 
-#endif
-
-
 namespace Poco {
 
 
@@ -357,9 +351,7 @@ void* ThreadImpl::runnableEntry(void* pThread)
 #endif
 
 	ThreadImpl* pThreadImpl = reinterpret_cast<ThreadImpl*>(pThread);
-#if defined(POCO_POSIX_DEBUGGER_THREAD_NAMES)
 	setThreadName(pThreadImpl->_pData->thread, reinterpret_cast<Thread*>(pThread)->getName());
-#endif
 	AutoPtr<ThreadData> pData = pThreadImpl->_pData;
 	try
 	{