Request: NetworkInterface::adapterName() #148

Closed
lbakman opened this Issue Apr 9, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@lbakman
Contributor

lbakman commented Apr 9, 2013

The NetworkInterface class provides two accessors to names: name() and displayName().

I would like to request that adapterName() be added to that list as some Windows network API's (DHCP is an example) use the AdapterName (GUID or LUID i believe) as input parameter.

I realise that there are helper functions for converting indexes to different names or identifiers but they are only available on Windows Vista or later.

On other operating systems I guess that the adapter name will be the same as name() and displayName() just as name() and displayName() are the same..

@aleks-f

This comment has been minimized.

Show comment
Hide comment
@aleks-f

aleks-f Apr 10, 2013

Member

I'm fine with this but if you want it in 1.5.2 , you'll have to implement it yourself and send pull request.

Member

aleks-f commented Apr 10, 2013

I'm fine with this but if you want it in 1.5.2 , you'll have to implement it yourself and send pull request.

@lbakman

This comment has been minimized.

Show comment
Hide comment
@lbakman

lbakman Apr 11, 2013

Contributor

I have submitted a pull request.

This is my first attempt at git so I hope I have done it correctly.

Contributor

lbakman commented Apr 11, 2013

I have submitted a pull request.

This is my first attempt at git so I hope I have done it correctly.

@ghost ghost assigned aleks-f Apr 12, 2013

@aleks-f

This comment has been minimized.

Show comment
Hide comment
@aleks-f

aleks-f Apr 12, 2013

Member

Looks good, I'll test it before 1.5.2 release.

Member

aleks-f commented Apr 12, 2013

Looks good, I'll test it before 1.5.2 release.

@aleks-f aleks-f closed this Apr 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment