New hash algorithms support for RSADigestEngine #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the hash before signing. That way we can then support RSA signatures with any hash supported by OpenSSL, not only MD5 and SHA1. It was also required a new method on DigestEngine to obtain the NID (numeric ID) of the algorithm, to be used on the OpenSSL RSA_sign call.
obiltschnig
added a commit
that referenced
this pull request
Mar 9, 2014
New hash algorithms support for RSADigestEngine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a improvement for RSADigestEngine to use Poco::Crypto::DigestEngine to calculate the hash before signing.
That way we can support RSA signatures with any hash supported by OpenSSL, not only MD5 and SHA1. It was also required a new method (nid()) on DigestEngine to obtain the NID (numeric object ID) of the algorithm, to be used on the OpenSSL RSA_sign call.
The original constructor for RSADigestEngine using the enumeration of MD5 and SHA1 algorithms is kept for backward compatibility but marked as deprecated (using comment only), but now also uses Poco::Crypto::DigestEngine instead the two instances Poco::MD5Engine and Poco::SHA1Engine.
A new test case was also created for a SHA256 RSA Signature.