Net::NameValueCollection::size() returns int #63

Closed
pprindeville opened this Issue Jan 12, 2013 · 0 comments

2 participants

@pprindeville

This function returns an int, despite the fact that the design pattern for a size() method is consistently std::size_t.

This method and others should be homogenized to return std::size_t since a signed value is inappropriate and generates (1) sign-conversion warnings when compiled with strict flags, and (2) an [ERRFMT] in Poco::format when you naively assume it's a %z format (as most ::size() return values would be).

Ditto for: Poco::TimedNotificationQueue, Poco::NotificationQueue, Poco::PriorityNotificationQueue, Poco::Manifest, Poco::Crypto/RSAKey, Poco::Crypto::RSAKeyImpl...

@obiltschnig obiltschnig added this to the Release 1.6.0 milestone Nov 19, 2014
@obiltschnig obiltschnig self-assigned this Nov 19, 2014
@obiltschnig obiltschnig added the fixed label Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment