GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Here is a fix for a problem I mentioned on the forum.
Don't call CloseHandle() twice on Windows (as it causes crashes, or u…
…nexpected behavior). This would happen with the following test case:
ProcessHandle handle = Process.launch(...);
Then as handle gets out of scope, ~ProcessHandle would call CloseHandle() on an already closed handle.
Just skimmed over it - wouldn't it be cleaner to make _handle mutable and leave const& arguments intact?
I'm on the road at the moment, but I will take a better look into it before release
This would work too, though in my opinion, it makes sense, semantically, if kill() modifies the ProcessHandle.
There was a related bugreport on SF:
"When severel thread tryies to call join on another one then CloseHandle could be called more then once with the same handle."
Adding it here, it will all be addressed together.
Ability to select the threadpool that will be used to start an Activity.