Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

* Fix JSON unicode handling #45

Merged
merged 2 commits into from Dec 29, 2012

Conversation

Projects
None yet
2 participants

Please add a test case for this change and verify/confirm that it does not break any existing unit tests.

Contributor

RangelReale commented Dec 28, 2012

I'm not an Unicode expert, please review if the test case I made is correct.
There were no errors on the JSON tests.

@aleks-f aleks-f added a commit that referenced this pull request Dec 29, 2012

@aleks-f aleks-f Merge pull request #45 from RangelReale/jsonunicode
* Fix JSON unicode handling
dcf92dc

@aleks-f aleks-f merged commit dcf92dc into pocoproject:develop Dec 29, 2012

@aleks-f aleks-f added a commit that referenced this pull request Dec 29, 2012

@aleks-f aleks-f Revert "Merge pull request #45 from RangelReale/jsonunicode"
This reverts commit dcf92dc, reversing
changes made to 79838aa.
52867ed

@aleks-f aleks-f added a commit that referenced this pull request Dec 29, 2012

@aleks-f aleks-f Revert "Revert "Merge pull request #45 from RangelReale/jsonunicode""
This reverts commit 52867ed.
86647bd
Owner

aleks-f commented Dec 29, 2012

I reverted this. The pull tests do pass but it's somewhat of a half-solution because it does not work for the OP case - the string ends up being internally converted into ???. It probably has to do with the current system code page but I have no time right now, maybe Franky can review it and come up with a more comprehensive set of tests.

@aleks-f aleks-f added a commit that referenced this pull request Dec 30, 2012

@aleks-f aleks-f Revert "Revert "Revert "Merge pull request #45 from RangelReale/jsonu…
…nicode"""

This reverts commit 86647bd.
26a480d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment