Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podlove-Player 2.1 gives incorrect links to timestamps #892

Closed
dieterbethke opened this issue Dec 14, 2016 · 3 comments
Closed

Podlove-Player 2.1 gives incorrect links to timestamps #892

dieterbethke opened this issue Dec 14, 2016 · 3 comments

Comments

@dieterbethke
Copy link

Expected behavior

When creating a share-link, it should look like this:
http://fotophonie.de/fotophonie-070-hello-again/?t=19:51.548

Actual behavior

But all i get is this:
http://fotophonie.de/fotophonie-070-hello-again/%23t%3D19:51.5483

There seems to be a problem with encoding of "/?t="

System information (see Podlove > Support menu)

Website http://fotophonie.de1
PHP Version 5.5.38-nmm2
WordPress Version 4.6.1
WordPress Theme Twenty Twelve v2.1
Publisher Version 2.4.0
Web Player Version 2.1.0
Twig Version 1.28.1
open_basedir ok
curl Version 7.22.0
iconv available
simplexml ok
max_execution_time 300
upload_max_filesize 200M
memory_limit 268435456
disable_classes
disable_functions
permalinks ok (/%postname%/)
podlove_permalinks ok
podcast_settings ok
web_player ok
podlove_cache on
assets

0 errors
0 notices
Nice, Everything looks fine!

@timpritlove
Copy link
Member

Yes, it's a long standing bug and should be fixed asap. Thanks for reporting.

@dieterbethke
Copy link
Author

Thanks for ACK. Any idea how long it will take to fix it ASAP?
Is it a good idea to patch the file podlove-web-player.min.js on my own in the meantime, as a hotfix?

@timpritlove
Copy link
Member

If you can do a patch, please consider submitting it as a pull request against this repo: https://github.com/podlove/podlove-web-player/commits/version-2.x-master (this issue is actually in the wrong repo and should probably be moved)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants