New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to specify visible components in v4 player #1032

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@blarghmatey
Copy link

blarghmatey commented Jan 25, 2019

In order to customize the appearance of the v4 player in the publishing plugin I added a form field to select which components are visible in the player embed. I also updated the default values for the primary and secondary color to pull from the configured theme settings.

@blarghmatey

This comment has been minimized.

Copy link
Author

blarghmatey commented Jan 25, 2019

The form field gets displayed but they don't appear to update if the form is submitted. This is also resulting in the preview of the player throwing an error. Any guidance on how to fix this, or an overview of how to add additional settings values would be appreciated.

@blarghmatey blarghmatey force-pushed the BoundlessNotions:player_v4_additional_configs branch 2 times, most recently from bea1a35 to d7042ca Jan 25, 2019

@blarghmatey

This comment has been minimized.

Copy link
Author

blarghmatey commented Jan 25, 2019

I fixed the problem with the player displaying now, but it still doesn't appear to be updating and displaying the selected components properly in the admin form.

@blarghmatey blarghmatey changed the title [WIP] Adding ability to specify visible components in v4 player Adding ability to specify visible components in v4 player Jan 26, 2019

@blarghmatey blarghmatey force-pushed the BoundlessNotions:player_v4_additional_configs branch from d7042ca to 16cb64d Jan 26, 2019

@blarghmatey

This comment has been minimized.

Copy link
Author

blarghmatey commented Jan 26, 2019

I added a way for the state of the configuration to be properly reflected in the settings form so this is ready for review and feedback.

@eteubert

This comment has been minimized.

Copy link
Member

eteubert commented Jan 27, 2019

Looks good on first glance. Nice detail, getting the default colors from WordPress :) I'll have a closer look soon, will probably land in the next release.

@blarghmatey

This comment has been minimized.

Copy link
Author

blarghmatey commented Jan 27, 2019

Great, thanks! 👍

Adding ability to specify visible components in v4 player
In order to customize the appearance of the v4 player in the publishing plugin I added a form field to select which components are visible in the player embed. I also updated the default values for the primary and secondary color to pull from the configured theme settings.

@blarghmatey blarghmatey force-pushed the BoundlessNotions:player_v4_additional_configs branch from 16cb64d to 059199c Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment