Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jQuery.fn.size() is deprecated #3898

Closed
pglewis opened this issue Dec 14, 2016 · 3 comments
Closed

jQuery.fn.size() is deprecated #3898

pglewis opened this issue Dec 14, 2016 · 3 comments
Assignees
@GaryJones
Labels
Focus: Deprecation
Milestone
Pods 2.7.4

Comments

@pglewis
Copy link
Contributor

pglewis commented Dec 14, 2016

https://github.com/pods-framework/pods/blob/30dff/ui/fields/media.php#L301
https://github.com/pods-framework/pods/blob/30dff/ui/js/jquery.pods.attach.js#L84
@pglewis
Copy link
Contributor Author

pglewis commented Dec 14, 2016

JQMIGRATE: jQuery.fn.size() is deprecated; use the .length property

@JoryHogeveen
Copy link
Member

@pglewis Is this a change for 2.7 or 2.6.8?

@pglewis
Copy link
Contributor Author

pglewis commented Dec 16, 2016

Probably 2.7 but it's small enough that it could be squeezed in whenever. I just stumbled over it while doing something else.

GaryJones added a commit that referenced this issue Jun 5, 2018
@GaryJones
JS: jQuery.fb.size() is deprecated
9491699 
Use `.length` property instead.

Fixes #3898
@GaryJones GaryJones mentioned this issue Jun 5, 2018
Merged
@ghost ghost assigned GaryJones Jun 5, 2018
@ghost ghost added the Status: In Progress Issue or PR is currently in progress but not yet done label Jun 5, 2018
@pglewis pglewis added this to the Pods 2.7.4 milestone Jun 5, 2018
@ghost ghost removed the Status: In Progress Issue or PR is currently in progress but not yet done label Jun 6, 2018
pglewis added a commit that referenced this issue Jun 6, 2018
@pglewis
Changelog for #3898
4512322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GaryJones GaryJones

Labels
Focus: Deprecation
Projects
None yet
Milestone
Pods 2.7.4
Development

No branches or pull requests
3 participants
@GaryJones @JoryHogeveen @pglewis