Don't show Taggable option for autocomplete with Simple Custom Defined List

[PodsBot]

Part of 2.7: #3364

[jimtrue]

Since the values of the field are defined in Pods Admin, there's no way for 'taggable' to insert a new field. In testing, the field 'acts' like it should work (ie it allows someone to tag a new value), but it doesn't save the value and doesn't update the field configuration. Taggable shouldn't be an option for Simple Custom Defined List.

[jimtrue]

Referenced from: https://wordpress.org/support/topic/confuse-about-taggable-relationship-field/

[sc0ttkclark]

Should be excluded on simple objects:
https://github.com/pods-framework/pods/blob/2.x/classes/fields/pick.php#L222

[sc0ttkclark]

Seems like it should be already:
https://github.com/pods-framework/pods/blob/2.x/classes/fields/pick.php#L167-L180

So something maybe not officially hiding it? Or is it being used from when it was previously set to on when a field was changed from a regular object to a simple one?

[pglewis]

Seems like it should be already

It's there, and the appropriate exclude class seems to be in place, but it's being shown. If hidden by choosing another view then re-selecting autocomplete it'll become visible again, so clearly something going on beyond just failing to initially hide it.

[pglewis]

I think we've decreed "death to taggable"? Does this issue evaporate with "Kill 'taggable' as an option" as a tasklist item in #4126?

[pglewis]

@sc0ttkclark: can we close this one since taggable is going by the wayside?

[sc0ttkclark]

Indeed

[pglewis]

Taggable may live on after all. Just in case, until the decision lands: re-opening.

[pglewis]

Still no idea what we're doing here. Moving to future release until we can specify what's to be done.

[jimtrue]

For Simple Custom Defined Lists, the only 'interface' to edit the choices in the Simple Custom Defined List is in the Pods Admin at the field level. So they can't have 'Add' or 'Edit' or anything that allows them to change the choices. They should only be able to select and de-select options.

[jimtrue]

Maybe change these fields to only be checkbox or select and not allow List View or Autocomplete? Or make sure that List View/Auto Complete makes sure 'Add New' 'Edit' is not allowed?

[pglewis]

This issue is specifically about the taggable option for autocomplete fields.

The taggable dependency doesn't work consistently as is and I have never tracked down why:

It's there, and the appropriate exclude class seems to be in place, but it's being shown. If hidden by choosing another view then re-selecting autocomplete it'll become visible again, so clearly something going on beyond just failing to initially hide it.

I think other options involving custom defined lists might be better in a separate issue from the programming perspective because taggable alone has specific issues that need to be worked out (like, are we even keeping it).

[jimtrue]

Specifically in relation to Simple Custom Defined Lists. I opened this one; I know what it refers to ;)