Title [PATCH] Improve html of mod_mirrorbrain
Priority feature Status resolved
Superseder Nosy List nick, poeml
Assigned To poeml Keywords mod_mirrorbrain
File name Uploaded Type Edit Remove
mod_mirrorbrain.patch nick, 2013-07-14.15:57:19 text/x-patch
The detailed files auto put of mod_mirrorbrain is not the most beatiful html in
the world and is also not very suitable for css styling. While it is possible to
this in the module itself.
So, an attempt that will suit kde (haven't asked, but I'm pretty sure it does)
and (more importantly) Xfce since I maintain that installation.
Changes in the patch:
I think the results is a nicer layout for users even in the plain layout and
will provide much better capabilities for webdesigners to integrate mirrorbrain
into their layout.
Did some testing (running at archive.xfce.org) and the resulted output was all
ok and html valid, but since we have a limited number of mirrors, not all types
of mirror array have been tested. But what could go wrong with copy-past hu?
Example output here:
Also available at github (https://github.com/nschermer/mod_mirrorbrain).
OT: would be nice if this was in fact hosted at github, makes contributions
easier. Just my opinion tho.
Great patch. I like it! Thank you so much.
I separated it from the other changed you did (like fixing the compiler warnings), so
it can be applied to the current SVN trunk. (I happened to fix the compiler warnings
already when I ran into then recently, not being aware of the details of your patch.)
It is a large patch and difficult to review in full length, but I'm sure it's a big
step forward also for other users, even though it might force some to update their
setups. But the better possibilities to adjust the looks should pay it back, I think.
I also applied commit 6a10d15b18617db10f172a8188f6345dd9962dae from
https://github.com/nschermer/mod_mirrorbrain now, which is a needed adjunct IMO.
In testing, I found something which -I think- was better before: the Google map
shows the entire world now, even when only a few mirrors in one country are
marked. That makes the data hard to see. Also it gives the false impression that
there all mirrors are concentrated in some part of the world, because only a
selection of ~10 mirrors is shown (also due to length of the URL constraints).
See this example:
Removing "¢er=0,0" scales the relevant part of the map to the entire window,
which I like much more because it really shows details:
P.S. Don't just click on the above links, you have to copy and paste them in
It gives a better picture in this case, I agree. I tested this with our mirror
list and also there it gives a better zoom level.
I get only positive feedback! I'm releasing 2.18.0 now.
Thanks again, Nick!
Date User Action Args
2014-02-04 19:31:03 poeml set status: testing -> resolved
messages: + msg519
2014-02-01 21:55:12 nick set messages: + msg507
2014-01-31 01:30:16 poeml set messages: + msg498
2014-01-31 01:29:23 poeml set messages: + msg497
2014-01-22 23:14:21 poeml set messages: + msg468
status: chatting -> testing
2014-01-22 22:45:40 poeml set assignedto: poeml
messages: + msg467
nosy: + poeml
2014-01-13 05:01:35 poeml set title: Improve html of mod_mirrorbrain ->
[PATCH] Improve html of mod_mirrorbrain
2013-07-15 15:24:11 nick set status: unread -> chatting
messages: + msg428
2013-07-14 15:57:19 nick create