New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theming of the 'details' page #63

Closed
poeml opened this Issue Jun 5, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@poeml
Owner

poeml commented Jun 5, 2015

                                                                                       [          ]

Issue migrated (2015-06-05) from old issue tracker http://mirrorbrain.org/issues/issue63

Title    theming of the 'details' page
 Priority   feature  Status   resolved
Superseder          Nosy List fukawi2, poeml
Assigned To         Keywords

msg241 (view) Author: fukawi2 Date: 2010-09-17.11:42:56

It would be good to be able to include a header and footer to the 'details' page
to be able to theme it correctly with the rest of the site.

Example:
This page - http://mirror.archserver.org/iso/sums.txt.mirrorlist
Should be themed like this page - http://mirror.archserver.org/iso/

A configuration directive to include a header and/or footer could be added to
mirrorbrain.conf

If a header is included, then MB should only output a

rather than a
complete page.

msg259 (view) Author: poeml Date: 2010-09-18.22:19:30

Adding Apache configuration directives for this purpose is easy and I'm happy to do it
(at least something I mastered meanwhile ;)

I assume that this implies that the header/footer would be read from disk (resp. out of
memory) each time, as HeaderName/ReadmeName in mod_autoindex do. But that should be
okay.

msg262 (view) Author: poeml Date: 2010-09-18.23:52:48

I have a working patch and am about to commit it to trunk. One thing I just
wonder is if the

container should already be included; after all, it could
also be added into the header and footer HTML. Maybe it is more flexible if it's
not happening hard-coded in mod_mirrorbrain. On the other hand, one more div
shouldn't harm either.

It looks like this now:

INJECTED_HEADER

Mirrors for ...
  ...
</ul>

INJECTED_FOOTER ##### msg263 (view) Author: poeml Date: 2010-09-19.00:10:08

Thinking further, I wonder whether the

container wouldn't be useful always,
or even more so, if running with the plain built-in HTML.

In conjunction with the existing MirrorBrainMirrorlistStyleSheet directive it
would allow some theming as well.

msg266 (view) Author: poeml Date: 2010-09-19.01:34:01

Patch in trunk:

http://svn.mirrorbrain.org/viewvc/mirrorbrain?view=revision&revision=8142
http://svn.mirrorbrain.org/viewvc/mirrorbrain?view=revision&revision=8143

http://svn.mirrorbrain.org/viewvc/mirrorbrain/trunk/mod_mirrorbrain/mod_mirrorbrai
n.c?r1=8143&r2=8141&pathrev=8143

History
         Date          User   Action            Args
2010-09-19 02:15:17 poeml   set    status: testing -> resolved
2010-09-19 01:34:07 poeml   set    status: chatting -> testing
2010-09-19 01:34:01 poeml   set    messages: + msg266
2010-09-19 00:10:08 poeml   set    messages: + msg263
2010-09-18 23:52:49 poeml   set    messages: + msg262
                                     status: unread -> chatting
2010-09-18 22:19:30 poeml   set    nosy: + poeml
                                     messages: + msg259
2010-09-17 11:42:56 fukawi2 create

(end of migrated issue)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment