New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md5 sum in Torrent info hash must be hex-encoded, not binary #77

Closed
poeml opened this Issue Jun 5, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@poeml
Owner

poeml commented Jun 5, 2015

                                                                                 [          ]

Issue migrated (2015-06-05) from old issue tracker http://mirrorbrain.org/issues/issue77

Title    md5 sum in Torrent info hash must be hex-encoded, not binary
 Priority   bug                    Status          resolved
Superseder                       Nosy List         poeml
Assigned To poeml                 Keywords         torrents

msg282 (view) Author: poeml Date: 2010-09-24.17:18:05

Apparently, the md5 sum in Torrent info hashes must be hex-encoded, not binary.

http://wiki.depthstrike.com/index.php/P2P:Protocol:Specifications:Optional_Hashes
claims this.

It means that sha1 comes in binary form and md5sum in hex-encoding, but well...

msg284 (view) Author: poeml Date: 2010-09-25.01:54:31

Fixed in trunk r8156.
http://svn.mirrorbrain.org/viewvc/mirrorbrain?view=revision&revision=8156

msg292 (view) Author: poeml Date: 2010-09-25.03:01:47

mb makehashes needed the same change, so that the info dict's hash (the bt info
hash) will match.
http://svn.mirrorbrain.org/viewvc/mirrorbrain?view=revision&revision=8161

History
         Date         User  Action             Args
2010-09-25 03:01:53 poeml set    status: chatting -> resolved
2010-09-25 03:01:48 poeml set    status: resolved -> chatting
                                   messages: + msg292
2010-09-25 01:54:32 poeml set    status: unread -> resolved
                                   messages: + msg284
2010-09-24 17:18:06 poeml create

(end of migrated issue)

@poeml poeml added bug resolved labels Jun 5, 2015

@poeml poeml closed this Jun 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment