fix: use signrawtransactionwithwallet (#947)

lautarodragan · web-flow · commit 6e32e048429e · 2019-07-03T19:49:22.000-03:00
diff --git a/docker-compose.yml b/docker-compose.yml
@@ -52,7 +52,6 @@ services:
       -rpcuser=bitcoinrpcuser
       -rpcpassword=bitcoinrpcpassword
       -rpcallowip=::/0
-      -deprecatedrpc=signrawtransaction
 
   bitcoind-2:
     image: ruimarinho/bitcoin-core:0.17.0
@@ -70,7 +69,6 @@ services:
       -rpcuser=bitcoinrpcuser
       -rpcpassword=bitcoinrpcpassword
       -rpcallowip=::/0
-      -deprecatedrpc=signrawtransaction
 
   k6:
     build:
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -56,7 +56,7 @@
   "dependencies": {
     "@po.et/poet-js": "5.1.17",
     "amqplib": "0.5.3",
-    "bitcoin-core": "2.0.0",
+    "bitcoin-core": "2.2.0",
     "bs58": "4.0.1",
     "form-data": "2.3.3",
     "ipfs-http-client": "28.1.0",
diff --git a/src/BlockchainWriter/Controller.ts b/src/BlockchainWriter/Controller.ts
@@ -180,7 +180,7 @@ export class Controller {
       'Got fundedTransaction from Bitcoin Core',
     )
 
-    const signedTransaction = await bitcoinCore.signRawTransaction(fundedTransaction.hex)
+    const signedTransaction = await bitcoinCore.signRawTransactionWithWallet(fundedTransaction.hex)
 
     logger.trace(
       {
diff --git a/typings/bitcoin-core.d.ts b/typings/bitcoin-core.d.ts
@@ -60,6 +60,7 @@ declare module 'bitcoin-core' {
     fundRawTransaction(hexstring: string, options?: FundRawTransactionOptions): Promise<FundRawTransactionResponse>
     setNetworkActive(flag: boolean): Promise<void>
     signRawTransaction(hexstring: string): Promise<SignRawTransactionResponse>
+    signRawTransactionWithWallet(hexstring: string): Promise<SignRawTransactionResponse>
     sendRawTransaction(hexstring: string): Promise<string>
     estimateSmartFee(blocks: number): Promise<EstimateSmartFeeResponse>
   }

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ export class Controller {`
`180`	`180`	`'Got fundedTransaction from Bitcoin Core',`
`181`	`181`	`)`
`182`	`182`
`183`		`- const signedTransaction = await bitcoinCore.signRawTransaction(fundedTransaction.hex)`
	`183`	`+ const signedTransaction = await bitcoinCore.signRawTransactionWithWallet(fundedTransaction.hex)`
`184`	`184`
`185`	`185`	`logger.trace(`
`186`	`186`	`{`
Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,7 @@ declare module 'bitcoin-core' {`
`60`	`60`	`fundRawTransaction(hexstring: string, options?: FundRawTransactionOptions): Promise<FundRawTransactionResponse>`
`61`	`61`	`setNetworkActive(flag: boolean): Promise<void>`
`62`	`62`	`signRawTransaction(hexstring: string): Promise<SignRawTransactionResponse>`
	`63`	`+ signRawTransactionWithWallet(hexstring: string): Promise<SignRawTransactionResponse>`
`63`	`64`	`sendRawTransaction(hexstring: string): Promise<string>`
`64`	`65`	`estimateSmartFee(blocks: number): Promise<EstimateSmartFeeResponse>`
`65`	`66`	`}`