New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate RabbitMQClient and Messaging #66

Open
lautarodragan opened this Issue Apr 11, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@lautarodragan
Copy link
Member

lautarodragan commented Apr 11, 2018

We currently have business specific logic inside our RabbitMQ Client, that we're calling Messaging.

Messaging should have the po.et-specific things, and the start, publish and consume should be extracted to a RMQClient.

Messaging should receive an instance of the client as parameter or create it itself.

Once they are finally separate, avoid any logging in the RMQ Client or Messaging — communicating only via callbacks, throws and returns.

@lautarodragan lautarodragan referenced this issue Apr 12, 2018

Merged

Pino JS #65

@geoffturk geoffturk changed the title Refactor: Separate RabbitMQClient and Messaging Separate RabbitMQClient and Messaging May 23, 2018

@geoffturk geoffturk added the refactor label May 23, 2018

@geoffturk geoffturk removed the architecture label Jun 11, 2018

@geoffturk geoffturk added this to the PML1 milestone Nov 21, 2018

@geoffturk geoffturk removed this from the PML1 milestone Nov 29, 2018

@geoffturk geoffturk added ct-z and removed ct-z labels Nov 29, 2018

@geoffturk geoffturk added this to the PML1 milestone Nov 29, 2018

@lautarodragan

This comment has been minimized.

Copy link
Member Author

lautarodragan commented Dec 5, 2018

Comment by @kennylavender originally in https://github.com/poetapp/node/pull/836/files

Instead of receiving exchange configuration, a messaging object should be passed in that contains preconfigured functions to call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment