Add animation operator to Effect. #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
commented
Jun 6, 2022
Comment on lines
+179
to
+180
| /// When read from a trailing closure assertion in ``send(_:_:file:line:)`` or | ||
| /// ``receive(_:_:file:line:)``, it will equal the `inout` state passed to the closure. |
Member
Author
There was a problem hiding this comment.
unrelated docc warning fixes.
stephencelis
reviewed
Jun 7, 2022
| import Combine | ||
| import SwiftUI | ||
|
|
||
| extension Publisher { |
Member
There was a problem hiding this comment.
Given long-term thoughts on the Effect type, should we define this directly on Effect instead, or should we pull it out as a Combine helper and define it in CombineSchedulers, instead (though it admittedly isn't a scheduler-specific operation)?
stephencelis
approved these changes
Jun 7, 2022
Member
stephencelis
left a comment
stephencelis
left a comment
There was a problem hiding this comment.
Could merge as is, but if you agree it should be defined on Effect, could take that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was brought up a long time ago by @mayoff in the Swift forums, but at the time we didn't think it was necessary since scheduler animations seemed to cover all its use cases. However, with some of the concurrency updates we will be bringing to the library soon this kind of operator is going to be handy when used with
Effect.task.