Move ViewStore into root ComposableArchitecture directory #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
approved these changes
Jun 18, 2020
Member
mbrandonw
left a comment
mbrandonw
left a comment
There was a problem hiding this comment.
yep, thanks for doing this!
honghaoz
pushed a commit
to chouti-dev/swift-composable-architecture
that referenced
this pull request
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewStore is a core component of TCA that is useful in non-SwiftUI contexts as well. I think it belongs in the root directory alongside store, reducer, etc! One other idea is to move the SwiftUI specific funcs regarding Bindings, etc into an extension inside of the SwiftUI directory to really drive this distinction home. What do you think @mbrandonw @stephencelis?