Skip to content

Minor fixes in StackBasedNavigation.md #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2023
Merged

Minor fixes in StackBasedNavigation.md #2154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/ComposableArchitecture/Documentation.docc/Articles/StackBasedNavigation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ from the stack using ``StackState/pop(from:)``.

## Dismissal

Dismissing a feature in a stack is as simple as using mutating the ``StackState`` using one of its
Dismissing a feature in a stack is as simple as mutating the ``StackState`` using one of its
methods, such as ``StackState/popLast()``, ``StackState/pop(from:)`` and more:

```swift
Expand Down Expand Up @@ -315,7 +315,7 @@ with the parent.

## Testing

A huge benefit of using the tools of this library to model navigation stacks is that testing because
A huge benefit of using the tools of this library to model navigation stacks is that testing becomes
quite easy. Further, using "non-exhaustive testing" (see <doc:Testing#Non-exhaustive-testing>) can
be very useful for testing navigation since you often only want to assert on a few high level
details and not all state mutations and effects.
Expand Down Expand Up @@ -398,7 +398,7 @@ func testDismissal() {
```

Then we can send the `.incrementButtonTapped` action in the counter child feature inside the
stack in order to to confirm that the count goes up by one, but in order to do so we need to provide
stack in order to confirm that the count goes up by one, but in order to do so we need to provide
an ID:

```swift
Expand Down