Alert bug exploration #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Aug 10, 2020
| @@ -105,6 +105,7 @@ import SwiftUI | |||
| @available(tvOS 13, *) | |||
| @available(watchOS 6, *) | |||
| public struct ActionSheetState<Action> { | |||
| public let id = UUID() | |||
There was a problem hiding this comment.
I think it's safe to identify in this fashion.
stephencelis
commented
Aug 10, 2020
| @@ -163,16 +163,11 @@ extension View { | |||
| dismiss: Action | |||
| ) -> some View { | |||
|
|
|||
| let viewStore = ViewStore(store, removeDuplicates: { ($0 == nil) != ($1 == nil) }) | |||
There was a problem hiding this comment.
This was the primary issue. Replacing alert state outright would consider the change a duplicate.
stephencelis
commented
Aug 10, 2020
| @@ -127,23 +128,44 @@ public struct ActionSheetState<Action> { | |||
| @available(macOS, unavailable) | |||
| @available(tvOS 13, *) | |||
| @available(watchOS 6, *) | |||
| extension ActionSheetState: Equatable where Action: Equatable {} | |||
| extension ActionSheetState: Equatable where Action: Equatable { | |||
| public static func == (lhs: Self, rhs: Self) -> Bool { | |||
There was a problem hiding this comment.
Have to do custom implementations of Equatable, Hashable, and CustomDebugOutputConvertible now to avoid the UUID being different in tests...maybe you have a better idea than hiding a UUID inside?
mbrandonw
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user encountered a bug here: https://forums.swift.org/t/how-to-show-alerts-from-two-actions-one-after-the-other/39214
This branch should hopefully fix!