Skip to content

Conversation

@IanKeen
Copy link
Contributor

@IanKeen IanKeen commented Sep 6, 2021

Any async Effect (including fireAndForget) could result in a runtime crash when updating internal state like effectCancellables
This adds a debug warning to let users know

Any async Effect (including fireAndForget) could result in a runtime crash when updating internal state like `effectCancellables`
This adds a debug warning to let users know
Copy link
Member

@mbrandonw mbrandonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome addition @IanKeen!

We have a few tweaks we want to make to this idea, but we'll merge your PR and then open a new PR with the changes.

Thanks!

@mbrandonw mbrandonw merged commit c77c605 into pointfreeco:main Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants