Fix iOS 14 alert/confirmationDialog runtime crash #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
approved these changes
Dec 20, 2021
diederich
added a commit
to thebrowsercompany/swift-composable-architecture
that referenced
this pull request
Dec 30, 2021
& adjust to their changes, mainly dropping the outdated `store.assert` API ``` ➜ swift-composable-architecture git:(develop) ✗ git --no-pager log --oneline 0.28.1..0.31.0 9c162f4 (tag: 0.31.0, upstream/main) Fix iOS 14 alert/confirmationDialog runtime crash (pointfreeco#931) fe97ad6 Fix UIKit Case Study warning (pointfreeco#924) ff41e51 Limit async/await to Swift 5.5.2 (Xcode 13.2) (pointfreeco#923) 83ae32a Fix Speech deprecation warnings (pointfreeco#922) 35ca967 Don't use Store.scope or ViewStore.send in TestStore (pointfreeco#921) 706fda8 Bump Dependencies (pointfreeco#918) b85fb40 Run swift-format 23155a0 (tag: 0.30.0) Support concurrency backdeployment (pointfreeco#916) ef5201a Clean up Voice Memos demo (pointfreeco#915) 87f388b Further Modernize Demos (pointfreeco#914) 25f943c Deprecate TestStore.assert (pointfreeco#912) 99426bb Fix Task.sleep deprecation warnings (pointfreeco#911) 8af720a Run swift-format 63f2e77 Add reset button to form binding case (pointfreeco#910) d992e4c Run swift-format 921272e (tag: 0.29.0) ✨ Add support for accessibility modifiers on TextState (pointfreeco#863) edfe198 Fix typo in Tic-Tac-Toe demo (pointfreeco#905) 15c39e5 Update Xcode version from 13.0 to 13.1 (pointfreeco#901) c41f8c4 Remove duplicate debug (pointfreeco#888) 068333a Make AlertState.ButtonAction.type public (pointfreeco#871) 696c122 Update ci.yml a690937 Fix Alert Case Study (pointfreeco#860) b5719bf Update example app entry points and some minor changes (pointfreeco#859) 1437951 Fix `CaseLet` docs (pointfreeco#850) 3144393 ✨ Add actionless CaseLet overload (pointfreeco#848) 1a2b293 (iampatbrown/main) Fix typo in `BindingAction.pullback(_:)` docs (pointfreeco#830) d165966 Don't print to console when dumping state for ViewStore.debug (pointfreeco#829) fa4fa76 Update README.md ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a bunch of experimentation to figure out something that fixes #928, but this appears to work!