More Prelude cleanup: #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stephencelis
commented
Jun 21, 2017
stephencelis
commented
- More Array → Sequence polymorphism
- More Either conformances
- Separate Semigroup from Monoid
- More operator categorization
- More Array -> Sequence polymorphism - More Either conformances - Separate Semigroup from Monoid - More operator categorization
stephencelis
commented
Jun 21, 2017
| @@ -7,12 +7,6 @@ public func <*> <A, B> (fs: [(A) -> B], xs: [A]) -> [B] { | |||
| return fs.flatMap { f in xs.map(f) } | |||
| } | |||
|
|
|||
| public func foldMap<A, M: Monoid>(_ f: @escaping (A) -> M) -> ([A]) -> M { | |||
There was a problem hiding this comment.
Generalizing things here against Sequence.
| @@ -4,12 +4,12 @@ public enum Either<L, R> { | |||
| } | |||
|
|
|||
| extension Either { | |||
| public func either<A>(_ f: (L) -> A, _ g: (R) -> A) -> A { | |||
| public func either<A>(_ l2a: (L) -> A, _ r2a: (R) -> A) -> A { | |||
There was a problem hiding this comment.
Naming. I wish I had a clear path here and didn't care. 😶
| } | ||
| } | ||
|
|
||
| // MARK: - Extend |
There was a problem hiding this comment.
Lots of fun stuff here, but Extend is a new one.
| @@ -8,18 +8,10 @@ public func concat<S: Sequence>(_ xs: S) -> S.Element where S.Element: Monoid { | |||
|
|
|||
| extension String: Monoid { | |||
| public static let e = "" | |||
|
|
|||
| public static func <>(lhs: String, rhs: String) -> String { | |||
There was a problem hiding this comment.
Moved append to Semigroup.
| } | ||
| } | ||
|
|
||
| public struct Sum<A: Numeric> { |
There was a problem hiding this comment.
Dunno if we want Factor, First, Last, Min, Max, and other wrappers, but may be useful and fun.
There was a problem hiding this comment.
(Stuff we may use more generally: Endo, Const, Id…)
mbrandonw
approved these changes
Jun 21, 2017
|
Added! And merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.