Set minimum version to iOS 11.0 to fix issues with weak linking of SwiftUI #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@thedavidharris Unfortunately I'm still getting those same errors when I run |
Contributor
Author
|
@stephencelis forgot to update the Podspec. Not on a machine I can validate it, but I think that would be why |
Contributor
Author
|
Yeah, just checked, this does fix |
zweigraf
added a commit
to SwiftRex/TestingExtensions
that referenced
this pull request
Jun 18, 2020
Using https://github.com/thedavidharris/swift-snapshot-testing.git, .revision(64c1925) for now, as the current release of SnapshotTesting does not compile. See this issue for more details: pointfreeco/swift-snapshot-testing#350 We are waiting for this PR to be merged, then we can revert this change: pointfreeco/swift-snapshot-testing#355
stephencelis
approved these changes
Jun 19, 2020
Member
stephencelis
left a comment
stephencelis
left a comment
There was a problem hiding this comment.
Looks great, thanks! Surprised tvOS didn't need to be bumped...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to fix #350. Can verify by just doing an Xcode archive on this. Did not see any need to make changes to the tvOS or macOS targets, those seems to remain okay.