Add S-PWQFN-N16 with 1.7x1.7 EP #590
Conversation
|
Code Climate has analyzed commit 7379203 and detected 0 issues on this pull request. View more on Code Climate. |
|
Could I get a review on this one? I have a symbol pending that depends on this footprint. |
|
Of course! Sooner or later. Probably later. There are 122 open PRs and yours is four (!) days old. Hint: Not creating additional work for reviewers is among the best ways to get a review in time. |
|
Oh, my apologies. I wasn't aware of the backlog, and I didn't mean to be pushy. The symbol is not pending as a PR yet. Will post as soon as the footprint is merged. Take your time, thanks for your work, and sorry again! |
|
That's not how it works. |
There was a problem hiding this comment.
There is nothing special about this QFN footprint.
Please use its default name of WQFN-16-1EP_3x3mm_EP1.7x1.7mm and move the size definition to https://github.com/pointhi/kicad-footprint-generator/blob/master/scripts/Packages/Package_NoLead__DFN_QFN_LGA_SON/size_definitions/qfn/wqfn.yaml
Edit: Also, please remove all commented lines.
| EP_size_x: | ||
| nominal: 1.7 | ||
| tolerance: 0.1 | ||
| EP_size_y: | ||
| nominal: 1.7 | ||
| tolerance: 0.1 |
There was a problem hiding this comment.
Please use the package pad dimensions of 1.66mm for EP_size_[xy] and add EP_size_[xy]_overwrite: 1.7 to get the suggested EP land size.
| paste_via_clearance: 0.1 | ||
| EP_paste_coverage: 0.5 |
There was a problem hiding this comment.
Please remove to use script defaults.
|
Thanks for the feedback. While adding moving it to the other location, I realized there is a definition already that serves the need quite well. Don't know why I didn't see that before. Sorry for the noise, I'll just go for the already existing option then. |
No description provided.