allow users to override the python package name to install #58

Closed
wants to merge 3 commits into
from

Projects

None yet

4 participants

@AnalogJ
AnalogJ commented Nov 8, 2013

allow users to override the python package names. This is important with AWS Opsworks, the package python installs python 2.6, if you want to install python 2.7 you have to use the package named python27

All you have to do now to override the installed package is set the attribute to the package names you want

default['python']['python_pkgs'] = ["python27", "python27-devel"]

AnalogJ added some commits Nov 8, 2013
@AnalogJ AnalogJ allow users to override the python package names. This is important w…
…ith AWS Opsworks, the package `python` installs python 2.6, if you want to install python 2.7 you have to use the package named `python27`
e05c5d8
@AnalogJ AnalogJ Update default.rb 810997f
@AnalogJ AnalogJ update to use a dynamic python binary path (the prefix and the binary…
… name can be changed using attributes)
f4e343a
@eric-tucker

Not to offend, but this seems to have been solved much more elegantly in this PR:
#90

@estebistec

well, it appears that this is actually making way more changes that the summary would suggest. I've been having trouble lining up my schedule to get onto opscode's code review sessions, but if/when I get #90 pushed through, this PR could at least be reduced by that much and maybe re-summarized/re-described for the other things it is doing.

@coderanger
Member

@estebistec Opscode is no longer involved in this repo, so their code review meetings have no sway here.

@AnalogJ
AnalogJ commented Feb 27, 2014

@eric-tucker No need to worry about offending me, the change in #90 is much cleaner. It has been a while since I've worked with this code, but from what I remember, some of my additional changes were due to issues with pip or pip packages installing under the wrong python binary.

If you want I can take another look at this PR over the weekend and rebase it off of #90

@estebistec

@coderanger Oh yeah? I guess that simplifies that.

How about the nginx cookbook?

@AnalogJ AnalogJ closed this Dec 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment