Skip to content
Browse files

Fix LLVM compiler warnings

  • Loading branch information...
1 parent 188a196 commit 546c2fd0a85739084e30945f0caded0a1a42fd38 @pokeb committed Jul 2, 2010
View
2 Classes/ASIAuthenticationDialog.h
@@ -31,5 +31,5 @@ typedef enum _ASIAuthenticationType {
@property (retain) ASIHTTPRequest *request;
@property (assign) ASIAuthenticationType type;
@property (assign) BOOL didEnableRotationNotifications;
-@property (retain) UIViewController *presentingController;
+@property (retain, nonatomic) UIViewController *presentingController;
@end
View
4 Classes/ASIDownloadCache.h
@@ -40,8 +40,8 @@
// Do not use this formatter for parsing dates because the format can vary slightly - use ASIHTTPRequest's dateFromRFC1123String: class method instead
+ (NSDateFormatter *)rfc1123DateFormatter;
-@property (assign) ASICachePolicy defaultCachePolicy;
-@property (retain) NSString *storagePath;
+@property (assign, nonatomic) ASICachePolicy defaultCachePolicy;
+@property (retain, nonatomic) NSString *storagePath;
@property (retain) NSRecursiveLock *accessLock;
@property (assign) BOOL shouldRespectCacheControlHeaders;
@end
View
17 Classes/ASIDownloadCache.m
@@ -47,6 +47,15 @@ - (void)dealloc
[super dealloc];
}
+- (NSString *)storagePath
+{
+ [[self accessLock] lock];
+ NSString *p = [[storagePath retain] autorelease];
+ [[self accessLock] unlock];
+ return p;
+}
+
+
- (void)setStoragePath:(NSString *)path
{
[[self accessLock] lock];
@@ -276,6 +285,14 @@ - (BOOL)isCachedDataCurrentForRequest:(ASIHTTPRequest *)request
return YES;
}
+- (ASICachePolicy)defaultCachePolicy
+{
+ [[self accessLock] lock];
+ ASICachePolicy cp = defaultCachePolicy;
+ [[self accessLock] unlock];
+ return cp;
+}
+
- (void)setDefaultCachePolicy:(ASICachePolicy)cachePolicy
{
View
8 Classes/ASIHTTPRequest.h
@@ -751,10 +751,10 @@ extern unsigned long const ASIWWANBandwidthThrottleAmount;
@property (retain,setter=setURL:) NSURL *url;
@property (retain) NSURL *originalURL;
-@property (assign) id delegate;
-@property (assign) id queue;
-@property (assign) id uploadProgressDelegate;
-@property (assign) id downloadProgressDelegate;
+@property (assign, nonatomic) id delegate;
+@property (assign, nonatomic) id queue;
+@property (assign, nonatomic) id uploadProgressDelegate;
+@property (assign, nonatomic) id downloadProgressDelegate;
@property (assign) BOOL useKeychainPersistence;
@property (assign) BOOL useSessionPersistence;
@property (retain) NSString *downloadDestinationPath;
View
34 Classes/ASIHTTPRequest.m
@@ -24,7 +24,7 @@
// Automatically set on build
-NSString *ASIHTTPRequestVersion = @"v1.7-10 2010-07-02";
+NSString *ASIHTTPRequestVersion = @"v1.7-11 2010-07-02";
NSString* const NetworkRequestErrorDomain = @"ASIHTTPRequestErrorDomain";
@@ -461,13 +461,30 @@ - (void)appendPostDataFromFile:(NSString *)file
[stream close];
}
+- (id)delegate
+{
+ [[self cancelledLock] lock];
+ id d = [[delegate retain] autorelease];
+ [[self cancelledLock] unlock];
+ return d;
+}
+
- (void)setDelegate:(id)newDelegate
{
[[self cancelledLock] lock];
delegate = newDelegate;
[[self cancelledLock] unlock];
}
+- (id)queue
+{
+ [[self cancelledLock] lock];
+ id q = [[queue retain] autorelease];
+ [[self cancelledLock] unlock];
+ return q;
+}
+
+
- (void)setQueue:(id)newQueue
{
[[self cancelledLock] lock];
@@ -1334,6 +1351,13 @@ - (void)updateProgressIndicators
}
}
+- (id)uploadProgressDelegate
+{
+ [[self cancelledLock] lock];
+ id d = [[uploadProgressDelegate retain] autorelease];
+ [[self cancelledLock] unlock];
+ return d;
+}
- (void)setUploadProgressDelegate:(id)newDelegate
{
@@ -1348,6 +1372,14 @@ - (void)setUploadProgressDelegate:(id)newDelegate
[[self cancelledLock] unlock];
}
+- (id)downloadProgressDelegate
+{
+ [[self cancelledLock] lock];
+ id d = [[downloadProgressDelegate retain] autorelease];
+ [[self cancelledLock] unlock];
+ return d;
+}
+
- (void)setDownloadProgressDelegate:(id)newDelegate
{
[[self cancelledLock] lock];
View
4 Classes/ASINetworkQueue.h
@@ -80,8 +80,8 @@
// This method will start the queue
- (void)go;
-@property (assign,setter=setUploadProgressDelegate:) id uploadProgressDelegate;
-@property (assign,setter=setDownloadProgressDelegate:) id downloadProgressDelegate;
+@property (assign, nonatomic, setter=setUploadProgressDelegate:) id uploadProgressDelegate;
+@property (assign, nonatomic, setter=setDownloadProgressDelegate:) id downloadProgressDelegate;
@property (assign) SEL requestDidStartSelector;
@property (assign) SEL requestDidReceiveResponseHeadersSelector;
View
4 iPhone.xcodeproj/project.pbxproj
@@ -781,7 +781,7 @@
GCC_OPTIMIZATION_LEVEL = 0;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "iPhone Sample/iPhone_Prefix.pch";
- GCC_VERSION = 4.2;
+ GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
INFOPLIST_FILE = "iPhone Sample/iPhoneInfo.plist";
IPHONEOS_DEPLOYMENT_TARGET = 2.2.1;
PRODUCT_NAME = "ASIHTTPRequest iPhone";
@@ -799,7 +799,7 @@
COPY_PHASE_STRIP = YES;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "iPhone Sample/iPhone_Prefix.pch";
- GCC_VERSION = 4.2;
+ GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
INFOPLIST_FILE = "iPhone Sample/iPhoneInfo.plist";
IPHONEOS_DEPLOYMENT_TARGET = 2.2.1;
PRODUCT_NAME = "ASIHTTPRequest iPhone";

0 comments on commit 546c2fd

Please sign in to comment.
Something went wrong with that request. Please try again.