Skip to content
Browse files

Tweaks

  • Loading branch information...
1 parent 4246c78 commit 7eda18bb4f57e9ceb07ab0e3914d15c47c69f7fc @pokeb committed Jul 13, 2009
Showing with 4 additions and 5 deletions.
  1. +2 −2 Classes/ASIHTTPRequest.m
  2. +2 −2 Classes/ASIS3Request.h
  3. +0 −1 Classes/ASIS3Request.m
View
4 Classes/ASIHTTPRequest.m
@@ -683,8 +683,8 @@ - (void)updateUploadProgress
return;
}
- // If this is the first time we've written to the buffer, byteCount will be the size of the buffer (currently seems to be 128KB on both Mac and iPhone)
- // If request body is less than 128KB, byteCount will be the total size of the request body
+ // If this is the first time we've written to the buffer, byteCount will be the size of the buffer (currently seems to be 128KB on both Mac and iPhone 2.2.1, 32KB on iPhone 3.0)
+ // If request body is less than the buffer size, byteCount will be the total size of the request body
// We will remove this from any progress display, as kCFStreamPropertyHTTPRequestBytesWrittenCount does not tell us how much data has actually be written
if (totalBytesSent > 0 && uploadBufferSize == 0 && totalBytesSent != postLength) {
[self setUploadBufferSize:totalBytesSent];
View
4 Classes/ASIS3Request.h
@@ -15,7 +15,7 @@ extern NSString *const ASIS3AccessPolicyPrivate; // This is the default in S3 wh
extern NSString *const ASIS3AccessPolicyPublicRead;
extern NSString *const ASIS3AccessPolicyPublicReadWrote;
extern NSString *const ASIS3AccessPolicyAuthenticatedRead;
-
+bug report in lighthouse
@interface ASIS3Request : ASIHTTPRequest {
// Your S3 access key. Set it on the request, or set it globally using [ASIS3Request setSharedAccessKey:]
@@ -27,7 +27,7 @@ extern NSString *const ASIS3AccessPolicyAuthenticatedRead;
// Name of the bucket to talk to
NSString *bucket;
- // path to the resource you want to access on S3. Leave empty for the bucket root
+ // Path to the resource you want to access on S3. Leave empty for the bucket root
NSString *path;
// The string that will be used in the HTTP date header. Generally you'll want to ignore this and let the class add the current date for you, but the accessor is used by the tests
View
1 Classes/ASIS3Request.m
@@ -113,7 +113,6 @@ - (void)generateS3Headers
[self setPath:@""];
}
-
NSString *canonicalizedResource = [NSString stringWithFormat:@"/%@/%@",[self bucket],[self path]];
// Add a header for the access policy if one was set, otherwise we won't add one (and S3 will default to private)

0 comments on commit 7eda18b

Please sign in to comment.
Something went wrong with that request. Please try again.