sslProperties leak #1207 of ASIHTTPRequest.m #296

Closed
ZuYuanZhou opened this Issue Dec 9, 2011 · 3 comments

Comments

Projects
None yet
4 participants

I add autorelease to it.

NSDictionary *sslProperties = [[[NSDictionary alloc] initWithObjectsAndKeys:
[NSNumber numberWithBool:YES], kCFStreamSSLAllowsExpiredCertificates,
[NSNumber numberWithBool:YES], kCFStreamSSLAllowsAnyRoot,
[NSNumber numberWithBool:NO], kCFStreamSSLValidatesCertificateChain,
kCFNull,kCFStreamSSLPeerName,
nil] autorelease];

Coeur commented Dec 9, 2011

Many people already requested this pull:
#282
#284
#288
#294

And many forks implement it:
https://github.com/yllan/asi-http-request/

dirkdk commented Dec 21, 2011

I'd personally not do autorelease but release at the end of the block. And yes it's a nobrainer. XCode Analyzer reports it pretty nicely

Collaborator

jogu commented Jan 13, 2012

Fix merged, thanks everyone.

@jogu jogu closed this Jan 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment