Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where only the first stone evolution would be triggered #519

Merged
merged 3 commits into from Jan 9, 2020

Conversation

Ishadijcks
Copy link
Collaborator

No description provided.

Copy link
Member

@RedSparr0w RedSparr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@fujnw
Copy link
Contributor

fujnw commented Jan 9, 2020

The random evolution works as intended, good to merge.

There're some UI/notification oddities though. The Item panel will show the pokeball beside Eevee only when both its Time_stone evolutions are obtained, which is fine, as long as we're aware of this behavior.

What's a little more strange, is if you have a ton of Time_stones and start hunting for shiny. Stone usage stops when a shiny is encountered (intended behavior). So the first time one of the evolution is shiny, you stop using stones and get a notification saying you caught a shiny - all is good. But the second time you catch a shiny, if it happens to be the one you already caught, you will still stop using stones. In this case, you'll get notified that you used X stones, but won't get notified on why it stopped. This will repeat until you catch the shiny of the other evolution.

This is not a big deal. And seeing that Time stone isn't available in Underground, players likely won't have a ton of them. But we should be aware of this.

@RedSparr0w
Copy link
Member

There're some UI/notification oddities though. The Item panel will show the pokeball beside Eevee only when both its Time_stone evolutions are obtained, which is fine, as long as we're aware of this behavior.

It was set up this way so the user should be more aware that they still haven't obtained all the evolutions, although I think this should only affect Eevee anyway.

@RedSparr0w
Copy link
Member

Does Tyrogue evolve correctly?
He has 3 possible evolutions via leveling.

@Ishadijcks Ishadijcks merged commit 83441fb into develop Jan 9, 2020
@Ishadijcks Ishadijcks deleted the fix/multiple-stone-evolutions branch January 9, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants