Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for block comments to comment action #297

Open
pokey opened this issue Oct 17, 2021 · 2 comments
Open

Add support for block comments to comment action #297

pokey opened this issue Oct 17, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pokey
Copy link
Member

pokey commented Oct 17, 2021

The defaulted scope type for the comment action should be line and if it is not line then we should use the editor.action.blockComment action

edit (@pokey, based on suggestion from @SCdF: We should use the removal range instead of the content range, so that eg if you're commenting out an argument, it would also comment out the comma

@pokey pokey added the enhancement New feature or request label Oct 17, 2021
@pokey pokey added this to To do in New modes of interaction via automation Jan 12, 2022
@pokey pokey added the good first issue Good for newcomers label Jan 16, 2022
@AndrewDant
Copy link
Contributor

Should this instead be a new block comment action that wraps all targeted text in a block comment? That would allow for block commenting things that aren't across multiple lines, and generally more fine tuned control of comment style.

@pokey
Copy link
Member Author

pokey commented Jun 8, 2022

The idea is to have the comment action determine what style of comment to use based on the scope type that comes in. Have a look at how ToggleBreakpoint determines whether to use a line breakpoint or inline breakpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Development

No branches or pull requests

2 participants