-
Notifications
You must be signed in to change notification settings - Fork 10
Add "Absolute Average Fold Error" and "Balanced Average Precision" to the metrics #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cwognum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Ah I see you created https://github.com/polaris-hub/polaris-hub/issues/317. |
cwognum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add some test cases? Especially for the multi-class one, this sounds like something that could fail.
cwognum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @zhu0619 , this is probably a bigger change than you anticipated by now! Sorry. Think we're almost there! Let me know if you need help. Happy to jump in.
Co-authored-by: Cas Wognum <caswognum@outlook.com>
Co-authored-by: Cas Wognum <caswognum@outlook.com>
cwognum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @zhu0619, I had one big question I would be curious to hear your thoughts on. Other than that, just some small comments.
cwognum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zhu0619 ! This is turning into a nice feature that will make the metric system more flexible moving forward.
Co-authored-by: Cas Wognum <caswognum@outlook.com>
cwognum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @zhu0619 ! Looks great!
Changelogs
Checklist:
feature,fixortest(or ask a maintainer to do it for you).discussion related to that PR