Skip to content

chore: Update skip condition for integration tests #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2025
Merged

chore: Update skip condition for integration tests #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcfca20
chore: Tweak integration tests
jstlaurent Jan 31, 2025
09dca52
Have settings ignore empty string values for environment variables
jstlaurent Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion polaris/hub/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ class PolarisHubSettings(BaseSettings):
"""

# Configuration of the pydantic model
model_config = SettingsConfigDict(env_file=".env", env_prefix="POLARIS_", extra="ignore")
model_config = SettingsConfigDict(
env_file=".env", env_prefix="POLARIS_", extra="ignore", env_ignore_empty=True
)

# Hub settings
hub_url: HttpUrlString = "https://polarishub.io/"
Expand Down
9 changes: 5 additions & 4 deletions tests/test_hub_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import os

import pytest

import polaris as po
from polaris.benchmark._base import BenchmarkSpecification
from polaris.dataset._base import BaseDataset
from polaris.hub.settings import PolarisHubSettings

settings = PolarisHubSettings()


@pytest.mark.skipif(
os.getenv("POLARIS_PASSWORD") is None and os.getenv("POLARIS_USER") is None,
settings.username is None or settings.password is None,
reason="This test case requires headless authentication to be set up",
)
def test_load_dataset_flow():
Expand All @@ -17,7 +18,7 @@ def test_load_dataset_flow():


@pytest.mark.skipif(
os.getenv("POLARIS_PASSWORD") is None and os.getenv("POLARIS_USER") is None,
settings.username is None or settings.password is None,
reason="This test case requires headless authentication to be set up",
)
def test_load_benchmark_flow():
Expand Down