Skip to content

Updating column adapter logic and usage #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 2, 2024
Merged

Updating column adapter logic and usage #86

merged 4 commits into from
Apr 2, 2024

Conversation

@Andrewq11
Copy link
Contributor

@Andrewq11 Andrewq11 commented Apr 2, 2024

Changelogs

  • Updated the attribute name in the BaseArtifactModel which indicates the current Polaris client version from version to polaris_version
  • Fixed column adapter logic by introducing a conversion map and updating how the conversion is applied on dataset retrieval

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

@Andrewq11 Andrewq11 added the fix Annotates any PR that fixes bugs label Apr 2, 2024
@Andrewq11 Andrewq11 requested a review from cwognum April 2, 2024 19:46
cwognum
cwognum approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@cwognum cwognum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just a minor suggestion! Thanks, @Andrewq11 !

@cwognum cwognum merged commit 5257351 into main Apr 2, 2024
@cwognum cwognum deleted the fix/column-adapters branch April 2, 2024 21:10
@cwognum
Copy link
Collaborator

cwognum commented Apr 2, 2024

Thanks @Andrewq11 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwognum cwognum cwognum approved these changes

@jstlaurent jstlaurent Awaiting requested review from jstlaurent

@mercuryseries mercuryseries Awaiting requested review from mercuryseries

Assignees

No one assigned

Labels

fix Annotates any PR that fixes bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Andrewq11 @cwognum