-
Notifications
You must be signed in to change notification settings - Fork 10
feat: Copy a Zarr archive to the Hub using copy_store for increased efficient #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwognum
requested changes
Apr 9, 2024
Collaborator
cwognum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lmtroper! I believe we can we use the same on download! It should speed things up further!
cwognum
reviewed
Apr 9, 2024
Collaborator
|
@lmtroper Can you replace |
3 tasks
cwognum
reviewed
Apr 9, 2024
cwognum
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelogs
Replaced
copy_allwithcopy_storewhen copying a Zarr archive to the Hub. The changes should increase efficiency ascopy_storedoes not de-compress and re-compress the data during copying (see documentation here).Below is the impact it had on profiling:
With
copy_all:With
copy_store:Note: We did not implement
copy_storefor downloading datasets (only uploading) as it resulted in an increase in caching the dataset locally. See below:copy_storefor both upload and download:copy_storefor just upload: