Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: purpose of ubuntu.tar.gz #1470

Closed
jdkent opened this issue Jan 16, 2019 · 7 comments
Closed

Question: purpose of ubuntu.tar.gz #1470

jdkent opened this issue Jan 16, 2019 · 7 comments
Labels

Comments

@jdkent
Copy link
Collaborator

jdkent commented Jan 16, 2019

I am using the fmriprep .circleci/config.yml as a template for NiMARE (e.g. neurostuff/NiMARE#62) (this config has a lot of useful features! 馃挴 ), and I am curious what the purpose of the ubuntu.tar.gz is and whether it is necessary.

@oesteban
Copy link
Member

that tarball contains the docker layers of the ubuntu image.

@effigies
Copy link
Member

I believe the idea was to reduce the odds of needing to pull down the Ubuntu image from docker hub, and thus the odds of rebuilding the entire image. There's a lot of debris in this file from trying to reuse layers from previous builds, because Circle does not play nicely with Docker except in the paid plans.

@jdkent
Copy link
Collaborator Author

jdkent commented Jan 16, 2019

I see, thanks! I linked where the image gets loaded from the cache, but where/when did the image get first saved to cache? I couldn't see an obvious command that said to save ubuntu.tar.gz in cache.

@effigies
Copy link
Member

Oh, looks like it's gone. We can probably remove that line, then.

@jdkent
Copy link
Collaborator Author

jdkent commented Jan 16, 2019

I can take care of that.

EDIT: on second thought, this may be a great first issue for anyone looking to contribute.
AFAIK that line is harmless, and it would allow a first time contributor to focus on git-flow.

@emdupre
Copy link
Collaborator

emdupre commented Jan 16, 2019

Major 馃樆 to that, @jdkent ! I think all we need to do is add the right issue label(s).

@oesteban
Copy link
Member

Sorry for the educational value of that line, but I forgot of this discussion and removed it in 1bf4a21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants