Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate that interpolation is NN above the EPI-to-T1w reportlet #1538

Open
oesteban opened this Issue Mar 13, 2019 · 3 comments

Comments

2 participants
@oesteban
Copy link
Contributor

oesteban commented Mar 13, 2019

@oesteban oesteban added this to To do in Low hanging fruits via automation Mar 13, 2019

@sarenseeley

This comment has been minimized.

Copy link
Contributor

sarenseeley commented Mar 13, 2019

Hi @oesteban, I added some explanation to the lines you indicated. Specifically, I added "Note that Nearest Neighbor interpolation is used in the reportlets in order to highlight potential spin-history and other artifacts, whereas final images are resampled using Lanczos interpolation." Let me know if this explanation is not accurate, or if you'd like me to change it in some other way.

Here's the edited file: https://www.dropbox.com/s/y6vz4aq4nzl9749/config.json?dl=0

@oesteban

This comment has been minimized.

Copy link
Contributor Author

oesteban commented Mar 14, 2019

Hi @sarenseeley, would you mind creating a Pull Request for this?

Since you are modifying just one file, you should be able to add the explanation (which looks pretty good, IMHO) using this link https://github.com/poldracklab/fmriprep/edit/master/fmriprep/viz/config.json

The reason is that this way the changes will be assigned to your user and you'll become an fMRIPrep contributor.

@sarenseeley

This comment has been minimized.

Copy link
Contributor

sarenseeley commented Mar 14, 2019

Done. Hopefully I did this correctly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.