Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect alignment of resampled results when SBRefs have mismatched xforms #1684

Open
oesteban opened this issue Jul 3, 2019 · 2 comments

Comments

@oesteban
Copy link
Contributor

commented Jul 3, 2019

Related to #1511 .

Example:

sub-3010_task-rest_run-1_bold.nii.gz               float32 [100, 100,  64, 989]  2.20x2.20x2.20x0.68   sform
sub-3010_task-rest_run-1_sbref.nii.gz               int16  [100, 100,  64,   4]  2.20x2.20x2.20x6.00   sform

and the following s-forms / codes

sub-3010_task-rest_run-1_bold.nii.gz
[[ -2.20000005   0.           0.         108.88800049]
 [  0.          -2.19230008  -0.18399933 121.40699768]
 [  0.          -0.1839013    2.19229198 -66.99874878]
 [  0.           0.           0.           1.        ]] / 1
sub-3010_task-rest_run-1_sbref.nii.gz
[[ -2.20000005   0.          -0.         108.88800049]
 [ -0.           2.19230056  -0.18389861 -95.63275146]
 [  0.           0.18389806   2.19230723 -85.20471191]
 [  0.           0.           0.           1.        ]]  / 1

lead to misalignments in the outputs.

@oesteban oesteban added this to the 1.4.1 milestone Jul 3, 2019

@oesteban oesteban self-assigned this Jul 3, 2019

@oesteban oesteban added this to To do in pipelines via automation Jul 3, 2019

@oesteban

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

I'm pushing this away from 1.4.1 because this will require a deep refactor. I've identified two issues:

  1. FSL MCFLIRT does not interpret correctly the headers of the reference image - when the SBRef has mismatched x-forms (and especially in this case where there is an axis flip) the alignment will just not work (maybe #1354 would help?)

  2. The resampling workflows generate references from the BOLD dataset instead of the SBRef.

@oesteban oesteban removed this from the 1.4.1 milestone Jul 5, 2019

@oesteban

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

A potential shortcut to fix this is poldracklab/niworkflows#253

@franklin-feingold franklin-feingold moved this from To do to Issues B-list in pipelines Jul 10, 2019

@oesteban oesteban added this to the 1.4.3 milestone Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.