Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md from dMRIPrep? #1808

Open
oesteban opened this issue Oct 8, 2019 · 4 comments

Comments

@oesteban
Copy link
Contributor

@oesteban oesteban commented Oct 8, 2019

Probably of particular interest to @emdupre, @ariveradompenciel and @jdkent who have worked on the contributor guidelines in the past.

We've been doing some work on the CONTRIBUTING.md file of dMRIPrep, which was initially based on the fMRIPrep's one.

But now I believe we could feed in the reversed directions. In particular:

  • The Impostor's syndrome disclaimer
  • The revised git workflow (includes creating a branch to work on PR)
  • The description of the impact:* and effort:* issue labels.
  • Finally, the description of creators and contributors (names match Zenodo's available roles) should probably need more adaptations but could be helpful to define more clearly the role of people who want to be kept in the core and others who prefer to see things happening and chime in for particular topics they are interested in. Anyway, a more explicit statement about how authorship and publications will be handled would be nice to have.

WDYT?

@emdupre

This comment has been minimized.

Copy link
Collaborator

@emdupre emdupre commented Oct 8, 2019

This looks fantastic 😍 I'm very much 👍 on bringing in some of these changes.

Let me know if there's anything I can do to help !

@jdkent

This comment has been minimized.

Copy link
Collaborator

@jdkent jdkent commented Oct 8, 2019

I'm on the same page as @emdupre, this looks great (going to have to port this to my projects as well).

I like seeing the explicit rules for publications, on first pass they all look reasonable, would posters fall under the same guidelines? (excluding the recommendation to post to a preprint server)

@ariveradompenciel

This comment has been minimized.

Copy link
Contributor

@ariveradompenciel ariveradompenciel commented Oct 8, 2019

Also agree, looks good! Let me know how I can help as well.

@oesteban

This comment has been minimized.

Copy link
Contributor Author

@oesteban oesteban commented Oct 8, 2019

I like seeing the explicit rules for publications, on first pass they all look reasonable, would posters fall under the same guidelines? (excluding the recommendation to post to a preprint server)

We've been pretty liberal as regards posters and abstracts because pulling together these many people seems to be a block for actually submitting these kinds of work. It's better to disseminate fMRIPrep although sometimes the author list should've been more inclusive. Happy to chat about this and have something written down to clarify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.