Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[ENH] Initial adoption of templateflow #1334
Changes proposed in this pull request
Documentation that should be reviewed
Ah sorry. There are more comments on my earlier question than I realized.
Part of the reason I haven't commented more (apart from that) is that I'm having trouble thinking clearly about the end goal of what we want space/template specification to be. I think if we're going to change the CLI, we should be fairly confident that we'll be sticking with those options for a while. So my questions are really:
Just as a reminder for any other participants, the reason we pulled
@effigies could you give me more detail about point 1? Is the potential concern that
I personally find it more clear to have
I don't think this would be against BEP 014. On the contrary, the metadata of the transform files will need to include a key indicating the image that was used as reference in registration. So, changing the name from
I agree this is mostly a renaming, however it makes conceptually easier the implementation of the various behaviors we want to see. Additionally, the PR will not remove the old command line arguments as they will go through a deprecation cycle that we can make as long as we consider necessary.
I am a bit undecided about
referenced this pull request
Oct 30, 2018
I also will defer to your judgement @oesteban -- both for this CLI and for its alignment with BEP014 !
I did want to add, though, the fact that this is confusing to other maintainers does raise a bit of a concern for me. Could we add any additional documentation here, outside of just the CLI rendering ? I'm thinking in particular that it could go in the processing pipeline details.