Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[FIX] Remove non-steady-state volumes prior to ICA-AROMA #1335
Changes proposed in this pull request
This pull request pulls the steady state detector into
Documentation that should be reviewed
I need to update the documentation for ica-aroma, more details to come...
effigies left a comment
This overall looks good. I left some comments on these functions.
I think testing is a good idea. The rule for tests is: if the function you're testing is in
Hi @effigies, Thanks for the helpful review! I've integrated the changes you suggested in the last commit, but I have not written tests yet. I think I will be able generate tests by friday, but if not, I can make it a separate pull request, and have this one merged as is (if all the tests pass).