Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

writing my GSoC'18 report #17

Merged

Conversation

nikita-astronaut
Copy link
Contributor

:))

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some style comments here and there, but it's mostly done :)


It was a lazy sunday at home and nothing prepared me for my GF giving me the link for the GSoC'18 announcement page. I was considering participation a year ago, but had not enough resoluteness for that. This year I wanted it to be different so I started scrolling through the list of open-source organisations. As I am doing a PhD in theoretical physics now (defending in Jnauary 2019), I wanted the project to be scientific, not just some boring back-end development (in which I am anyway not strong enough). After a couple of iterations I converged to three space-aimed organisations. What shocked me, was the fact that mostly people of these organizations were not eager to even answer simple questions or it took them a week to provide a dataset for analysis. Only in Poliastro it was easy enough to get in touch with people and they (especially Juan) turned out to be friendly and helpful. In such an atmosphere it is more than possible to work.

After looking project proposal list, I found what I am strong at and made a compilation of three project proposals into my own final [proposal](https://storage.googleapis.com/summerofcode-prod.appspot.com/gsoc/core_project/doc/5416846749073408_1521547584_proposal_astrakhantsev.pdf?Expires=1533564319&GoogleAccessId=summerofcode-prod%40appspot.gserviceaccount.com&Signature=OkUaCTO50Xy4dLVGKpUPlbsqj2XYI3QZRX8GriDapFoSpjV0xs%2F4zy2WD%2Fwj1dNZHxHYXppE7GR7i6D0cDjuarlWp6OwYPnoiBdCfh7Fg3UG8WjGWjOXE9oP8Jer2QA3teG5U9xYHgtStzTd9uQRA%2FA14qOQg0nVzJvCocIjYVWPROipz9V08uzhMbPISEX4AlGs2G5KC4F08P3D%2Bf4AaYsh6euug6JxY40zOrOZCwm%2Bg0Jh6s1kpB9XDeIzMb9Qdb06YFpLpQUggVNW7v7fPxuM188qEiNTdMR%2BvuMhnpgC1cV22%2FIB3l3xvPlFiJ%2BjpoDIw%2FX1JXHbfeQpl%2BUQzg%3D%3D) and got accepted.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExpiredTokenThe provided token has expired.Request has expired: 1533564319

Not sure if there's a way to generate a public URL for the proposal? If not, it's a good moment to upload it to the wiki :)

lang: en
Author: Nikita Astrakhantsev

It was a lazy sunday at home and nothing prepared me for my GF giving me the link for the GSoC'18 announcement page. I was considering participation a year ago, but had not enough resoluteness for that. This year I wanted it to be different so I started scrolling through the list of open-source organisations. As I am doing a PhD in theoretical physics now (defending in Jnauary 2019), I wanted the project to be scientific, not just some boring back-end development (in which I am anyway not strong enough). After a couple of iterations I converged to three space-aimed organisations. What shocked me, was the fact that mostly people of these organizations were not eager to even answer simple questions or it took them a week to provide a dataset for analysis. Only in Poliastro it was easy enough to get in touch with people and they (especially Juan) turned out to be friendly and helpful. In such an atmosphere it is more than possible to work.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sunday Sunday, Jnauary January, Juan Juan Luis (that's my full name 😇)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's "my GF"? possibly I'm missing some silly thing here :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted the project to be scientific, not just some boring back-end development

haha, I feel your pain!!

During the GSoC, I was writing a [blog on Medium](https://medium.com/@nikita.astronaut). You can actually see how I was becoming more and more tired till the end as the length of post was gradually shrinking :) Still, there I was trying to describe all the things we've done and give all the links to merged pull requests. Below I will repeat that in more of a shorter manner, giving links to PRs and corresponding Medium posts :)

## So what was done (in chronological order)?
1. [Bonding period](https://medium.com/@nikita.astronaut/my-bonding-period-working-for-gsoc18-poliastro-project-3aa10732b7c0). Fixed non-smoothness in orbit-plotting [here](https://github.com/poliastro/poliastro/pull/320), added mean_motion propagator [here](https://github.com/poliastro/poliastro/pull/322) and made it possible to propagate orbit to desired true anomaly [here](https://github.com/poliastro/poliastro/pull/334). Added J2 perturbation [here](https://github.com/poliastro/poliastro/pull/341), atmospheric drag [here](https://github.com/poliastro/poliastro/pull/343), fixed Newton method and Kepler propagator convergence [here](https://github.com/poliastro/poliastro/pull/362).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use backticks for all the code references? mean_motion, Orbit.sample (also: orbit Orbit), etc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, perhaps you want to replace things like

Fixed non-smoothness in orbit-plotting here, added mean_motion propagator here

by

Fixed non-smoothness in orbit-plotting, added mean_motion propagator

## So what was done (in chronological order)?
1. [Bonding period](https://medium.com/@nikita.astronaut/my-bonding-period-working-for-gsoc18-poliastro-project-3aa10732b7c0). Fixed non-smoothness in orbit-plotting [here](https://github.com/poliastro/poliastro/pull/320), added mean_motion propagator [here](https://github.com/poliastro/poliastro/pull/322) and made it possible to propagate orbit to desired true anomaly [here](https://github.com/poliastro/poliastro/pull/334). Added J2 perturbation [here](https://github.com/poliastro/poliastro/pull/341), atmospheric drag [here](https://github.com/poliastro/poliastro/pull/343), fixed Newton method and Kepler propagator convergence [here](https://github.com/poliastro/poliastro/pull/362).
2. [First milestone, first part](https://medium.com/@nikita.astronaut/the-end-of-may-in-gsoc18-poliastro-project-2d3ed2d6c9e0). Wrote my own DOP853 solver in python!! [here](https://github.com/poliastro/poliastro/pull/368) and optimized orbit.sample method using now accessible dense output [here](https://github.com/poliastro/poliastro/pull/379).
3. [First milestone, second part](https://medium.com/@nikita.astronaut/the-detective-story-3rd-body-perturbation-validation-8b260086ea0d). After a veeery long search for mistake in validation (it actually turned out to be mistake in BOOK), added 3rd-body perturbation [here](https://github.com/poliastro/poliastro/pull/381).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it actually turned out to be mistake in BOOK

do we have a public comment stating this thing where we can link?

2. [First milestone, first part](https://medium.com/@nikita.astronaut/the-end-of-may-in-gsoc18-poliastro-project-2d3ed2d6c9e0). Wrote my own DOP853 solver in python!! [here](https://github.com/poliastro/poliastro/pull/368) and optimized orbit.sample method using now accessible dense output [here](https://github.com/poliastro/poliastro/pull/379).
3. [First milestone, second part](https://medium.com/@nikita.astronaut/the-detective-story-3rd-body-perturbation-validation-8b260086ea0d). After a veeery long search for mistake in validation (it actually turned out to be mistake in BOOK), added 3rd-body perturbation [here](https://github.com/poliastro/poliastro/pull/381).
4. [Second milestone, first part](https://medium.com/@nikita.astronaut/solar-drag-and-robust-kepler-equation-solution-694a4658c35b). Added solar drag perturbation [here](https://github.com/poliastro/poliastro/pull/388), changed the source of docs download [here](https://github.com/poliastro/poliastro/pull/390) and implemented better treatment of parabolic region in mean_motion propagator [here](https://github.com/poliastro/poliastro/pull/394).
5. [Second milestone, second part](https://medium.com/@nikita.astronaut/ending-of-2nd-evaluation-period-new-propagator-in-parabolic-region-j3-perturbation-continuous-17042f85d8b3). Added J3-perturbations [here](https://github.com/poliastro/poliastro/pull/398) and artificial perturbations from the old Juan's code [here](https://github.com/poliastro/poliastro/pull/400).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment about the experimental status of J3?

6. [Third milestone](https://medium.com/@nikita.astronaut/making-propagators-fast-again-and-more-a8df832ca7ec). Made propagators fasted by using numba [here](https://github.com/poliastro/poliastro/pull/409) and [there](https://github.com/poliastro/poliastro/pull/413), added continuous benchmarking of propagators [here](https://github.com/poliastro/poliastro-benchmarks/pull/16) and spent some time documenting and demonstrating new features from this summmer [here](https://github.com/poliastro/poliastro/pull/428).

## Conclusion
So, as you can see, quite some work has been done and I got really tired :) However, I want to thank Juan for his continuous assessment and support, for teaching me right code structuring and using github. Juan was always ready to help and save me from any bugs, which made all these contributions possible. This was a real experience and I am happy that I agreed to take part in it :)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astrojuanlu astrojuanlu merged commit 5072622 into poliastro:sources Aug 7, 2018
@astrojuanlu
Copy link
Member

Merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants