This repository was archived by the owner on Oct 14, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Oct 14, 2023. It is now read-only.
Unit conversion error when using newer astroquery #1229
Description
I think we broke the docs after I merged some of the recent pull requests: either #1184 or #1190, both by @Yash-10.
Here's the latest failed build:
https://readthedocs.org/projects/poliastro/builds/13776407/
UnitConversionError: Can only apply 'add' function to quantities with compatible dimensions
there's a units problem in the NEOs notebook.
Activity
astrojuanlu commentedon May 16, 2021
Both Read the Docs and our
py38_online_testcheck have failed, see for example https://github.com/poliastro/poliastro/runs/2594411686.jtegedor commentedon May 16, 2021
I found the same while doing something else, I do not think it is related specifically to those PR.
After doing the changes here #1228, docs and pytest work again.
astrojuanlu commentedon May 16, 2021
Oh, now I know what's happening! The
from_sbdbold code looked weird to me, but I remembered it had to do with some weird astroquery thing. I checked their release notes and saw that astropy/astroquery#2011 has been released, hence the jplsbdb service now returns astropy quantities. It makes total sense to merge #1228, doing it now.astrojuanlu commentedon May 16, 2021
Closed in #1228 🚀
[-]Docs are broken[/-][+]Unit conversion error when using newer astroquery[/+]astrojuanlu commentedon May 30, 2021
For future readers: Until we release poliastro 0.15.1 with a fix for this, a solution is to downgrade astroquery: