New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attractor size when plotting different orbits #130

Closed
Juanlu001 opened this Issue Aug 7, 2016 · 3 comments

Comments

2 participants
@Juanlu001
Member

Juanlu001 commented Aug 7, 2016

No description provided.

@Juanlu001 Juanlu001 added this to the 0.6 milestone Aug 7, 2016

@Juanlu001 Juanlu001 removed this from the 0.6 milestone Feb 5, 2017

@Juanlu001 Juanlu001 modified the milestone: 0.7 Feb 12, 2017

@Juanlu001

This comment has been minimized.

Member

Juanlu001 commented Feb 26, 2017

Related to #111. Postponing.

@Juanlu001 Juanlu001 modified the milestones: Future, 0.7 Feb 26, 2017

@anhiga

This comment has been minimized.

Member

anhiga commented Aug 7, 2017

I was about to open an issue when I saw this one.

As title says, attractor size when plotting distant orbits seems too big.
figure_1

It can be fixed changing line 126 in plotting.py from:

radius = max(orbit.attractor.R.to(u.km).value, orbit.r_p.to(u.km).value / 6) 

to

radius = orbit.attractor.R.to(u.km).value

but I suppose that without that max statement, attractor would appear really small in most cases, so I don't know if there is any solution.

@Juanlu001

This comment has been minimized.

Member

Juanlu001 commented Aug 7, 2017

but I suppose that without that max statement, attractor would appear really small in most cases, so I don't know if there is any solution.

Yep, that's the problem. There is also another thing:

https://github.com/poliastro/poliastro/blob/286e524/src/poliastro/plotting.py#L125

The attractor is being plotted one time for each planet. We could always plot the "real" radius, and although it would be too small in most cases, it is the easiest way to fix a sensible value without ruining the plot. Perhaps we should plot the attractor only once in the first place?

@wafflebot wafflebot bot added the 2 - In Progress label Aug 7, 2017

@wafflebot wafflebot bot removed the 2 - In Progress label Aug 8, 2017

@Juanlu001 Juanlu001 modified the milestone: Future Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment