New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ephemerides functions with Astropy equivalents #131
Comments
First steps: barycentric velocities in Astropy astropy/astropy#5231 |
Astropy 1.3 is out 🎉 http://www.astropy.org/announcements/release-1.3.html In particular:
|
Using the class |
For some reason I'm not getting the same results with poliastro and the
|
Reason: it's using TDB scale in the background, see https://github.com/astropy/astropy/blob/v1.3/astropy/coordinates/solar_system.py#L218
|
Quoting the original report:
http://ipnpr.jpl.nasa.gov/progress_report/42-196/196C.pdf Therefore, poliastro has been almost correct, but wrong, since #42 was merged. I'm tagging this as a bug. |
After this change, we might want to add regression tests with strong tolerance checks. Idea: parametrize the tolerance locally so we can try a range of possible values and easily see the lowest one that fulfills the requirements. |
Also replace ephemerides functions, still there is some boilerplate involved. We will probably need to wrap Astropy here, see poliastro#131 for future work.
This replacement cannot be done until Astropy supports proper motions and velocities, see this bug:
astropy/astropy#4344
For instance,
get_body_barycentric
does not return the velocity of the planets, and therefore it's useless for our purposes.The text was updated successfully, but these errors were encountered: