This repository has been archived by the owner on Oct 14, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 279
Add bot to reformat code #1319
Comments
What sorcery is this 😱 pradyunsg/furo@37bfcc4 Looks like https://pre-commit.ci/ is what we need? |
I was going to say, Would you be open to a PR that simply implements Lines 64 to 72 in 2e38094
in |
Absolutely @matthewfeickert ! 🙌🏼 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When first-time contributors open a pull request, usually they are not aware that they have to run
tox -e reformat
before committing. Although we have documented these steps in ourCONTRIBUTING.md
(but not on our Contribute page!), it is normal that some people don't read it.What usually happens next is that we have to either merge code with a failing quality check (we almost never do that) or ask the user to amend some silly whitespace issues (which is annoying and not always fool-proof).
Instead of fighting against this, I propose we have a bot that we can ask
and then it pushes another commit to the same branch.
Similar examples:
@conda-forge-admin
, used in conda-forge recipes. See https://conda-forge.org/docs/maintainer/infrastructure.html#admin-web-services, source code at https://github.com/conda-forge/conda-forge-webservices/run-recipe-test
, used in pangeo recipes. See https://github.com/pangeo-forge/staged-recipes/blob/master/.github/workflows/run-recipe-test.yamlThe text was updated successfully, but these errors were encountered: