New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try creating a ClassicalElementsRepresentation #257

Open
Juanlu001 opened this Issue Oct 5, 2017 · 8 comments

Comments

3 participants
@Juanlu001
Member

Juanlu001 commented Oct 5, 2017

By creating a ClassicalElementsRepresentation we could integrate better with the astropy.coordinates machinery, including transformation from/to other representations.

Here is the guide on how to do it:

http://docs.astropy.org/en/v2.0.2/coordinates/representations.html#creating-your-own-representations

Some problems that might arise:

  • Different units for each element
  • Singularities
  • ?
@anhiga

This comment has been minimized.

Member

anhiga commented Oct 6, 2017

It's a really good idea, but how could we deal with the gravitational parameter? It would be impossible to have a straight from_cartesian() transformation without knowing k.

@Juanlu001 Juanlu001 added the question label Oct 6, 2017

@Juanlu001

This comment has been minimized.

Member

Juanlu001 commented Oct 8, 2017

One could create a ClassicalElementsRepresentation based on a specific k:

ThisRep = ClassicalElementsRepresentation.from_k(...)

Then ThisRep would store k internally and allow conversions. What do you think?

@Juanlu001 Juanlu001 modified the milestones: Future, 0.9 Nov 15, 2017

@Juanlu001

This comment has been minimized.

Member

Juanlu001 commented Nov 20, 2017

I'm postponing this until we have better validation of reference frames, see #109.

@shreyasbapat

This comment has been minimized.

Member

shreyasbapat commented Jun 28, 2018

What I understand is:
We have to use CartesianRepresentation class to return the positions, but we are already doing that as _sample() already returns a CartesianRepresentation object. So, what are we talking about here? 😕

@shreyasbapat

This comment has been minimized.

Member

shreyasbapat commented Jun 28, 2018

Or, probably, we are planning to create a new class which could represent positions and name it ClassicalElementRepresentation ?

@Juanlu001

This comment has been minimized.

Member

Juanlu001 commented Jun 28, 2018

The thing is that now you can only sample position and velocity, it would be nice to sample any other thing (the true anomaly for example) and be able to convert that to a trajectory. So the idea would be to create a class that holds classical elements in an array, in the same way that CartesianRepresentation holds position and velocity in arrays.

@Juanlu001 Juanlu001 referenced this issue Jul 4, 2018

Merged

J3 adding #398

@Juanlu001

This comment has been minimized.

Member

Juanlu001 commented Jul 5, 2018

Let's move this to the next milestone. @eteq said on chat that it would be very nice to see this integrated on Astropy, although the question on how to treat velocities is still open.

@Juanlu001 Juanlu001 modified the milestones: 0.10, 0.11 Jul 5, 2018

@Juanlu001 Juanlu001 modified the milestones: 0.11, 0.12 Aug 30, 2018

@Juanlu001

This comment has been minimized.

Member

Juanlu001 commented Aug 30, 2018

Postponing this to the next milestone. There's some discussion that should happen though, so it's not clear we'll go this way.

@Juanlu001 Juanlu001 referenced this issue Sep 5, 2018

Merged

Frames improvements #446

3 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment