Skip to content
This repository was archived by the owner on Oct 14, 2023. It is now read-only.
This repository was archived by the owner on Oct 14, 2023. It is now read-only.

Astropy Affiliated Package Review #279

Closed
@astrofrog

Description

@astrofrog

This package has been re-reviewed by the Astropy coordination committee in relation to the Astropy affiliated package ecosystem.

We have adopted a review process for affiliated package that includes assigning quantitative ‘scores’ (red/orange/green) for different categories of review. You can read up more about this process here. (This document, currently in Google Docs, will be moved to the documentation in the near future.) For each of the categories below we have listed the score and have included some comments when the score is not green.

Functionality/ScopeSpecialized%20package
No further comments
Integration with Astropy ecosystemGood
In many places poliastro makes use of astropy constructs like time and units. However, in at least one place it does not use quantity where it could (poliastro.twobody). This might be a hold-over from before Quantity existed, in which case it is fine but might be on the roadmap for updating later on. In addition the docs for poliastro.coordinates say "this module complements astropy.coordinates". It looks like this may pre-date Astropy 2.0 in that it is mostly velocity-related machinery. Would be useful to know if that can be changed to be compatible with the new machinery, but it's not a problem right now because that's a new Astropy feature. But should be on the roadmap for updating (or updating astropy.coordinates if it isn't suitable for poliastro's needs)
DocumentationGood
No further comments
TestingPartial
Coverage could be improved a bit
Development statusHeavy%20development
Recent releases feature some backwards-incompatible changes, so we are classifying this as under "heavy development". However, we can change this to good if the plan is to have more stable releases in future.
Python 3 compatibilityGood
No further comments

Summary/Decision: Things are looking good, and this package meets the review criteria for
affiliated packages, so we are happy to confirm that we'll be listing your
package as an affiliated package! Keep up the good work, and we encourage you to
improve on the areas above that weren't “green” yet.

If you agree with the above review, please feel free to close this issue. If you have any follow-up questions or disagree with any of the comments above, leave a comment and we can discuss it here. At any point in future you can request a re-review of the package if you believe any of the scores should be updated - contact the coordination committee, and we’ll do a new review. Note that we are in the process of redesigning the http://affiliated.astropy.org page to show these scores (but not the comments). Finally, please keep the title of this issue as-is (“Astropy Affiliated Package Review”) to make it easy to search for affiliated package reviews in future.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions