Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrbitPlotter2D plots don't respect aspect ratio of circles #345

Closed
shreyasbapat opened this issue Apr 15, 2018 · 3 comments
Closed

OrbitPlotter2D plots don't respect aspect ratio of circles #345

shreyasbapat opened this issue Apr 15, 2018 · 3 comments
Labels
bug

Comments

@shreyasbapat
Copy link
Member

@shreyasbapat shreyasbapat commented Apr 15, 2018

I was just trying out the OrbitPlotter2D just introduced and I found that it shows terribly bad plots for poliastro.examples (or maybe more correctly, the objects very near to earth).
馃悶 Problem

Look at the plots of molniya and iss. The line appears in front of the body and becomes difficult to see. It can be the extension of #278

screenshot from 2018-04-15 12-23-45

馃枼 Please paste the output of following commands

conda info -a

python -c "import poliastro.testing; poliastro.testing.test()"

馃幆 Goal

It is important for one to be able to visualize the orbits using plotly. As in case of OrbitPlotter , the orbits can still be recognized.
馃挕 Possible solutions

We can probably change the colors of the orbit (Only in case of examples ?)
Or we may follow the proposed solutions in #278
馃搵 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 馃帀
@shreyasbapat shreyasbapat changed the title OrbitPlotter2D plots orbit in fron of the body OrbitPlotter2D plots orbit in front of/behind the body Apr 15, 2018
@astrojuanlu
Copy link
Member

@astrojuanlu astrojuanlu commented Apr 15, 2018

A new feature was added to plotly that allows you to draw fixed size shapes with respect to the axes:

plotly/plotly.js#2532

Can you try with the development version of plotly to see if it fixes the issue?

@shreyasbapat
Copy link
Member Author

@shreyasbapat shreyasbapat commented Apr 15, 2018

Yes! I will go through the PR to understand what they have done!

@astrojuanlu
Copy link
Member

@astrojuanlu astrojuanlu commented Apr 20, 2018

I'm labeling this as a bug so we give it the attention it deserves.

shreyasbapat added a commit to shreyasbapat/poliastro that referenced this issue May 11, 2018
@astrojuanlu astrojuanlu changed the title OrbitPlotter2D plots orbit in front of/behind the body OrbitPlotter2D plots don't respect aspect ratio of circles Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants