Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sun Incorrectly plotted in plot_solar_system #385

Closed
shreyasbapat opened this issue Jun 11, 2018 · 3 comments
Closed

Sun Incorrectly plotted in plot_solar_system #385

shreyasbapat opened this issue Jun 11, 2018 · 3 comments
Labels
bug
Milestone

Comments

@shreyasbapat
Copy link
Member

@shreyasbapat shreyasbapat commented Jun 11, 2018

The radius of the plotted sun exceeds the radii of some orbits of inner planets.
馃悶 Problem

See this figure:
screenshot from 2018-06-11 17-23-59

馃枼 Please paste the output of following commands

conda info -a

python -c "import poliastro.testing; poliastro.testing.test()"

pip freeze | grep astropy

pip freeze | grep poliastro

馃幆 Goal

馃挕 Possible solutions

馃搵 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 馃帀
@astrojuanlu astrojuanlu added the bug label Jun 11, 2018
@astrojuanlu
Copy link
Member

@astrojuanlu astrojuanlu commented Jun 11, 2018

Thanks @shreyasbapat! This must be a problem in the method that redraws the attractor, or the minimum radius. Do you want to try fixing it?

@shreyasbapat
Copy link
Member Author

@shreyasbapat shreyasbapat commented Jun 11, 2018

Yeah Sure! I will try to fix this.

shreyasbapat added a commit to shreyasbapat/poliastro that referenced this issue Jun 11, 2018
@astrojuanlu
Copy link
Member

@astrojuanlu astrojuanlu commented Jun 12, 2018

Closed in #387.

@astrojuanlu astrojuanlu added this to the 0.10 milestone Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants