Sure, go ahead! If you find any problems, just ask, here or in the chat. I
would expect a test if you are familiar with pytest, but if not we can
decide when you open a pull request.
On 24 Oct 2018 3:58 pm, "Andrés Arribas Flores" <firstname.lastname@example.org> wrote:
Since it's an easy fix, may I take care of it as an entry point to
contribute to the project?
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
or mute the thread
I noticed the function documentation comments are not consistent : Kepler function has none whereas mean_motion has some. The parameters are also inconsistently commented. May I also improve on that? Incidentally, I had a look at other .py in /core and noticed that a lot of doc comments where removed when the functions where "jitted". Was this intented? I found them useful.
@aarribas definitely - documentation is important to us, and if you noticed these inconsistencies we would be very happy if you fixed them as well (perhaps in separate commits though, so the review is easier). Also, we moved lots of functions to core in a rush, the day of the release, and at 3 AM local time, so I admit we probably missed lots of docstrings in the process.